Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature remove TODO for php < 5 #1536

Merged

Conversation

alamirault
Copy link
Contributor

Hi,

The PR remove a TODO for php < 5.

Hope it's ok

@CLAassistant
Copy link

CLAassistant commented Jul 24, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@richardm-stripe
Copy link
Contributor

Hello @alamirault, thank you for the contribution. Looks good to me.

@richardm-stripe richardm-stripe merged commit f44a7b4 into stripe:master Jul 24, 2023
@alamirault alamirault deleted the feature/remove-todo-constant-php-4 branch July 24, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants