fix: Transform error StripeObjects to ErrorObject. #1357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-stripe
approved these changes
Aug 23, 2022
dcr-stripe
force-pushed
the
dcr-php-errors
branch
from
7a87065 to
a159b0b
Compare
|
Closing this out - we opted for fixing the type hints (#1361) and then re-visiting this as part of the next major to handle this consistently across all SDKs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? kamil-stripe
Summary
Include the error types in the object type mapping and start transforming API objects returned with these types to
ErrorObject.Motivation
Fixes #1353
We explicitly state in the type annotation that these are
ErrorObjects but they weren't getting transformed appropriately.