Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Updates #1239

Merged
merged 2 commits into from
Feb 3, 2022
Merged

API Updates #1239

merged 2 commits into from
Feb 3, 2022

Conversation

yejia-stripe
Copy link
Contributor

@yejia-stripe yejia-stripe commented Feb 3, 2022

Codegen for openapi 10fe9f5.
r? @dcr-stripe
cc @stripe/api-libraries

Changelog

  • Add REASON_EXPIRED_UNCAPTURED_CHARGE enum value on Refund.

Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fixer doesn't seem to have run here (hence why there's so many unchanged files).

From stripe-php, can you run:

composer clean
composer install
 ./vendor/bin/php-cs-fixer fix -v --using-cache=no

That will reset your local install to bring it up to date with the latest CS fixer version and should now work! Let me know if you're having issues.

@stripe-ci stripe-ci assigned yejia-stripe and unassigned dcr-stripe Feb 3, 2022
@yejia-stripe
Copy link
Contributor Author

r? @dcr-stripe

Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - thanks Yejia! Maybe let's change the changelog to something like:

Add REASON_EXPIRED_UNCAPTURED_CHARGE enum value on Refund.

to be more accurate?

@stripe-ci stripe-ci assigned yejia-stripe and unassigned dcr-stripe Feb 3, 2022
@yejia-stripe yejia-stripe merged commit bfc3f8d into master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants