Trim spaces when parsing php.ini disablefunctions #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
force-pushed
the
richardm-forgive-spaces-in-disable-functions
branch
from
fa93c77 to
850ccad
Compare
ctrudeau-stripe
approved these changes
Sep 21, 2020
richardm-stripe
deleted the
richardm-forgive-spaces-in-disable-functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1009
r? @ctrudeau-stripe
cc @stripe/api-libraries
Summary: we were throwing exceptions by trying to call \php_uname on systems where \php_uname isn't supported because it was disabled in the php.ini, and we were not detecting the disabling correctly. I tested this by manually executing the function on my machine and setting various values of
disable_functionsinside my own /etc/php.ini.Thanks for the contribution in #1009 @flinebux. I took a slightly different approach because I wanted to try and add a test as well.