Merge pull request #624 from stripe/ob-fix-multipart-nested-params-en…

…coding Fix encoding of nested parameters in multipart requests
stripe · Apr 5, 2019 · f513348 · f513348
2 parents d14f02d + eeebf90
commit f513348
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/lib/File.php b/lib/File.php
@@ -50,6 +50,13 @@ public static function create($params = null, $options = null)
         if (is_null($opts->apiBase)) {
             $opts->apiBase = Stripe::$apiUploadBase;
         }
-        return static::_create($params, $opts);
+        // Manually flatten params, otherwise curl's multipart encoder will
+        // choke on nested arrays.
+        // TODO: use array_column() once we drop support for PHP 5.4
+        $flatParams = [];
+        foreach (\Stripe\Util\Util::flattenParams($params) as $pair) {
+            $flatParams[$pair[0]] = $pair[1];
+        }
+        return static::_create($flatParams, $opts);
     }
 }
diff --git a/tests/Stripe/FileCreationTest.php b/tests/Stripe/FileCreationTest.php
@@ -40,6 +40,7 @@ public function testIsCreatableWithFileHandle()
         $resource = File::create([
             "purpose" => "dispute_evidence",
             "file" => $fp,
+            "file_link_data" => ["create" => true]
         ]);
         $this->assertInstanceOf("Stripe\\File", $resource);
     }
@@ -63,6 +64,7 @@ public function testIsCreatableWithCurlFile()
         $resource = File::create([
             "purpose" => "dispute_evidence",
             "file" => $curlFile,
+            "file_link_data" => ["create" => true]
         ]);
         $this->assertInstanceOf("Stripe\\File", $resource);
     }

diff --git a/tests/Stripe/FileUploadCreationTest.php b/tests/Stripe/FileUploadCreationTest.php
@@ -40,6 +40,7 @@ public function testIsCreatableWithFileHandle()
         $resource = FileUpload::create([
             "purpose" => "dispute_evidence",
             "file" => $fp,
+            "file_link_data" => ["create" => true]
         ]);
         $this->assertInstanceOf("Stripe\\FileUpload", $resource);
     }
@@ -63,6 +64,7 @@ public function testIsCreatableWithCurlFile()
         $resource = FileUpload::create([
             "purpose" => "dispute_evidence",
             "file" => $curlFile,
+            "file_link_data" => ["create" => true]
         ]);
         $this->assertInstanceOf("Stripe\\FileUpload", $resource);
     }