Handle developer_message in preview responses (#1505)

stripe · May 25, 2023 · 40d6a38 · 40d6a38
1 parent acaaeb4
commit 40d6a38
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/lib/ApiRequestor.php b/lib/ApiRequestor.php
@@ -194,7 +194,7 @@ public function handleErrorResponse($rbody, $rcode, $rheaders, $resp)
      */
     private static function _specificAPIError($rbody, $rcode, $rheaders, $resp, $errorData)
     {
-        $msg = isset($errorData['message']) ? $errorData['message'] : null;
+        $msg = isset($errorData['message']) ? $errorData['message'] : (isset($errorData['developer_message']) ? $errorData['developer_message'] : null);
         $param = isset($errorData['param']) ? $errorData['param'] : null;
         $code = isset($errorData['code']) ? $errorData['code'] : null;
         $type = isset($errorData['type']) ? $errorData['type'] : null;

diff --git a/tests/Stripe/ApiRequestorTest.php b/tests/Stripe/ApiRequestorTest.php
@@ -503,6 +503,33 @@ public function testRaisesOAuthUnsupportedResponseTypeError()
         }
     }
 
+    public function testHandlesErrorWithDeveloperMessage()
+    {
+        $this->stubRequest(
+            'POST',
+            '/v1/charges',
+            [],
+            null,
+            false,
+            [
+                'error' => [
+                    'developer_message' => 'Unacceptable',
+                ],
+            ],
+            400
+        );
+
+        try {
+            Charge::create();
+            static::fail('Did not raise error');
+        } catch (Exception\InvalidRequestException $e) {
+            static::assertSame(400, $e->getHttpStatus());
+            static::assertSame('Unacceptable', $e->getMessage());
+        } catch (\Exception $e) {
+            static::fail('Unexpected exception: ' . \get_class($e));
+        }
+    }
+
     public function testHeaderStripeVersionGlobal()
     {
         Stripe::setApiVersion('2222-22-22');