Merge pull request #1562 from stripe/richardm-nicer-exception-tostring

Nicer ApiErrorException::__toString()
stripe · Aug 29, 2023 · 18d6862 · 18d6862
2 parents d7af9fc + a947b5e
commit 18d6862
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/Exception/ApiErrorException.php b/lib/Exception/ApiErrorException.php
@@ -202,10 +202,11 @@ public function setStripeCode($stripeCode)
      */
     public function __toString()
     {
+        $parentStr = parent::__toString();
         $statusStr = (null === $this->getHttpStatus()) ? '' : "(Status {$this->getHttpStatus()}) ";
         $idStr = (null === $this->getRequestId()) ? '' : "(Request {$this->getRequestId()}) ";
 
-        return "{$statusStr}{$idStr}{$this->getMessage()}";
+        return "Error sending request to Stripe: {$statusStr}{$idStr}{$this->getMessage()}\n{$parentStr}";
     }
 
     protected function constructErrorObject()

diff --git a/tests/Stripe/Exception/ApiErrorExceptionTest.php b/tests/Stripe/Exception/ApiErrorExceptionTest.php
@@ -44,5 +44,7 @@ public function testToString()
     {
         $e = $this->createFixture();
         static::compatAssertStringContainsString('(Request req_test)', (string) $e);
+        static::compatAssertStringContainsString('Error sending request to Stripe', (string) $e);
+        static::compatAssertStringContainsString('Stack trace:', (string) $e);
     }
 }