Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable request latency telemetry by default #649

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Enable request latency telemetry by default #649

merged 1 commit into from
Jun 25, 2019

Conversation

ob-stripe
Copy link
Contributor

@paulasjes-stripe
Copy link
Contributor

LGTM

@ob-stripe ob-stripe force-pushed the ob-enable-telemetry branch from cd27291 to 6a6dca9 Compare June 21, 2019 04:22
@rattrayalex-stripe
Copy link
Contributor

Can we add more detail about what sorts of telemetry are taking place?
Otherwise,

LGTM

@brandur-stripe
Copy link
Contributor

Can we add more detail about what sorts of telemetry are taking place?

IMO the call out in the README for "request latency telemetry" is probably good enough, but I guess it can't hurt to be as explicit anywhere we can.

LGTM.

@ob-stripe ob-stripe merged commit 1b65f12 into master Jun 25, 2019
@ob-stripe ob-stripe deleted the ob-enable-telemetry branch June 25, 2019 00:42
@ob-stripe
Copy link
Contributor Author

Released as 7.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ob-stripe ob-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ob-stripe @paulasjes-stripe @rattrayalex-stripe @brandur-stripe