-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥Remove deprecated methods 🔥 #613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Left a couple of questions, many of which are probably not issues with this PR but just things that differ For Reasons and will need to be addressed via codegeneration overrides.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome!
LGTM
once remi's questions have been addressed
(per IRL, we'll add recipients.listCards back in and then merge) |
0db7e03
to
51419c9
Compare
r? @rattrayalex-stripe @remi-stripe
cc @stripe/api-libraries @irace-stripe
Remove all deprecated methods, as documented in https://github.com/stripe/stripe-node/wiki/Migration-guide-for-v7.