Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Subscription Schedule resource #562

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

remi-stripe
Copy link
Contributor

r? @ob-stripe
cc @stripe/api-libraries

@remi-stripe remi-stripe force-pushed the remi-add-subscription-schedule branch from 70c229c to 6de84e7 Compare February 12, 2019 05:54
@remi-stripe
Copy link
Contributor Author

@ob-stripe This is now fully ready to review and merge.

Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some missing tests, otherwise LGTM.

test/resources/SubscriptionSchedule.spec.js Show resolved Hide resolved
@stripe-ci stripe-ci assigned remi-stripe and unassigned ob-stripe Feb 12, 2019
@remi-stripe remi-stripe force-pushed the remi-add-subscription-schedule branch from 6de84e7 to a138982 Compare February 12, 2019 16:20
@remi-stripe
Copy link
Contributor Author

@ob-stripe Fixed, PTAL

@remi-stripe remi-stripe assigned ob-stripe and unassigned remi-stripe Feb 12, 2019
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stripe-ci stripe-ci assigned remi-stripe and unassigned ob-stripe Feb 12, 2019
@remi-stripe remi-stripe merged commit 515b1ce into master Feb 12, 2019
@remi-stripe remi-stripe deleted the remi-add-subscription-schedule branch February 12, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants