Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted resources have an empty id string #56

Closed
ob-stripe opened this issue Apr 4, 2018 · 1 comment · Fixed by #57
Closed

Deleted resources have an empty id string #56

ob-stripe opened this issue Apr 4, 2018 · 1 comment · Fixed by #57

Comments

@ob-stripe
Copy link
Contributor

When replying to resource deletion requests, stripe-mock returns an empty string for the id attribute:

$ curl -X DELETE http://localhost:12111/v1/customers/cus_123 -H "Authorization: Bearer sk_test_123"
{
  "deleted": true,
  "id": ""
}

The live API sends back the ID of the deleted resource:

$ curl -X DELETE https://api.stripe.com/v1/customers/cus_... -u $STRIPE_SECRET_KEY:
{
  "id": "cus_...",
  "deleted": true
}
@brandur
Copy link
Contributor

brandur commented Apr 4, 2018

Ah, yep. That's definitely a problem. Thanks for opening.

brandur-stripe pushed a commit that referenced this issue Apr 4, 2018
Updates the bundled OpenAPI spec, with the most important piece being
that we now have fixtures that include deleted objects with real IDs.

Fixes #56.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants