-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new change event types #659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cskillingstad-stripe Looks good, just left one question on the CardNetwork type
@@ -297,3 +322,112 @@ export interface StripePaymentElementChangeEvent { | |||
}; | |||
}; | |||
} | |||
|
|||
type CardBrand = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have CardNetworkBrand already, would it make sense to use that instead? Also cartes_bancaires and a few others from CardNetworkBrand
are missing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is on purpose. We are only exposing the card brands that are publicly documented in the payment_method
card object: https://docs.google.com/document/d/1dNA70BIrlKuXw02nmTpkiRUMApxSKjaVeyVjI1vmvBQ/edit?pli=1#heading=h.bhsr8nwiiq7d.
This was a requirement from the cards team.
I'm surprised we're exposing those brands in CardNetworkBrand. There are types that the card-metadata service returns that aren't publicly documented
Summary & motivation
carddetailschange
,savedpaymentmethodupdate
, andsavedpaymentmethodremove
Testing & documentation