Tweak ordering of publish script #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hofman-stripe
approved these changes
Apr 27, 2020
package.json
Outdated
| @@ -14,7 +14,7 @@ | |||
| "typecheck": "tsc", | |||
| "build": "yarn clean && yarn rollup -c", | |||
| "clean": "rimraf dist", | |||
| "ci": "yarn lint && yarn test && yarn test:versions && yarn test:types && yarn typecheck && yarn build", | |||
| "ci": "yarn lint && yarn test && yarn test:versions && yarn test:types && yarn typecheck", | |||
There was a problem hiding this comment.
nit: Is ci still the appropriate description? Wondering if it shouldn't be something like
Suggested change
| "ci": "yarn lint && yarn test && yarn test:versions && yarn test:types && yarn typecheck", | |
| "test": "yarn test:lint && yarn test:unit && yarn test:versions && yarn test:types && yarn test:typecheck", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51
Ensures that the
package.jsonversion is bumped before the package is built, so that the correct version is embedded in the build.I'll make a similar change to react-stripe-js.