Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds "on" property handler to StripeIssuingCardNumberDisplayElement #419

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

madhav-stripe
Copy link
Contributor

Summary & motivation

Following conventions in other type definitions, we're adding an "on" property handler to the StripeIssuingCardNumberDisplayElement

closes #418

Testing & documentation

Tested locally

This api is already documented here

@rado-stripe
Copy link
Contributor

Probably missing a bunch of other methods like once, off etc, but ok to merge this as iterative improvement.

At some point we should look into adding on and friends into StripeElementBase, I think all elements have it.

@rado-stripe rado-stripe self-requested a review February 8, 2023 23:13
@rado-stripe rado-stripe merged commit 62e200f into master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Property 'on' does not exist on type 'StripeIssuingCardNumberDisplayElement' — but it does work
2 participants