Solution For "Regarding ability to override stripe api url per API re…

[yasirshabbir44]

…quest #1181".

#1181

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ yasirshabbir44
❌ javaProgrammer44
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[richardm-stripe]

Hello @yasirshabbir44. Thank you for this change. It makes sense to me!

Can you sign the CLA per CLAassistant's comment above?

[yasirshabbir44]

Hello @richardm-stripe
Done

[richardm-stripe]

Ah, I see you have changed src/main/java/com/stripe/model/PaymentMethod.java to replace Stripe.getApiBase() with options.getApiBase() but

• This file is generated, so we have to change the generator (which alas, is private) otherwise the change to this file will be reverted.
• Many other models also need to be changed to use options.getApiBase().
• We need to account for the possibility that options is null, since passing null RequestOptions is allowed into methods like PaymentMethod.create.

So we can't merge as-is. I'll see if I can get a generator change in this week.

[yasirshabbir44]

Waiting for to get merge if you all get well please merge it.

thanks

[richardm-stripe]

Hello @yasirshabbir44, I'm working on this and made a number of changes:

• I changed apiBase to baseUrl. I wanted to give it a different name from Stripe.apiBase because Stripe.connectBase (which defaults to connect.stripe.com) and Stripe.uploadBase (which defaulst to files.stripe.com) also exist, but specifying RequestOptions.baseUrl will override all of these, not just Stripe.apiBase.
• I changed it so that defaulting to Stripe.getApiBase() happens in a new method ApiResource.fullUrl which is called from each resource method. It needs to be this way, since we need to handle null RequestOptions, and methods that use connectBase or uploadBase need a way to specify that they have different defaults from other methods.
• I changed our generator so that all methods in the SDK respect RequestOptions.baseUrl and committed the resulting changes.

[richardm-stripe]

r? @pakrym-stripe

[yasirshabbir44]

Could you please merge it

[richardm-stripe]

Sure, we can merge! We aren't scheduled cut a release until next week, though.

[richardm-stripe]

Released in https://github.com/stripe/stripe-java/releases/tag/v22.5.0

[yasirshabbir44]

Hello Richard, I did changes and raised PR and that PR also got merged, but in the contributor list I cannot see my name. Why it’s not showing up? Thanks Yasir Shabbir

…

On Sat, 7 Jan 2023 at 2:15 AM Richard Marmorstein ***@***.***> wrote: Released in https://github.com/stripe/stripe-java/releases/tag/v22.5.0 — Reply to this email directly, view it on GitHub <#1476 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABUEYPCFHZTZQMVGXH7NOJDWRCKQBANCNFSM6AAAAAAR7VSX34> . You are receiving this because you were mentioned.Message ID: ***@***.***>