Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brandLogo on android does not show anything #100

Closed
Prakosa opened this issue Feb 24, 2023 · 5 comments
Closed

brandLogo on android does not show anything #100

Prakosa opened this issue Feb 24, 2023 · 5 comments

Comments

@Prakosa
Copy link

Prakosa commented Feb 24, 2023

Hi All,

I am using this SDK and all is working as expected, except the brandLogo in Android does not show anything.

in iOS it show as expected but on android it does not show anything.

brandLogo: Image.resolveAssetSource(images.brandIcon)

the format of brandIcon is png.

This is the crashlog from logcat in Android Studio.

Screen Shot 2566-02-24 at 16 45 48

it should working same as iOS.

please help me to solve this issue. thanks

@ccen-stripe
Copy link
Contributor

Hi @Prakosa, sorry for the delay but we just fixed this in stripe/stripe-android#6341, the Android release should be out on Monday, 13, 2023. Updating to the latest 0.1.4 by then should resolve this issue. Thanks!

@Prakosa
Copy link
Author

Prakosa commented Apr 18, 2023

Hi @ccen-stripe thanks for the update before. Unfortunately it still does not work when the app is build for release. It still does not show the logo you can check it by yourself. https://github.com/stripe/stripe-identity-react-native/releases/tag/v0.1.5 I even update the library but it still does not show the logo in release build.

@ccen-stripe ccen-stripe reopened this Apr 18, 2023
@Prakosa
Copy link
Author

Prakosa commented Apr 19, 2023

Once again sorry, can you make the logo are center. Thanks @ccen-stripe
IMG_5158

@ccen-stripe
Copy link
Contributor

hi @Prakosa it seems the logo does show up, could you verify if this is a false alarm? (This is the fix on Android SDK ICYMI)

Re. center the image - We follow material design guidelines for our Android SDK to left align the title and icons, this is different on on iOS SDKs where they are centered aligned

@ccen-stripe
Copy link
Contributor

feel free to reopen if it still persists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants