Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for API version 2018-09-24 #698

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Update for API version 2018-09-24 #698

merged 1 commit into from
Sep 27, 2018

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe @remi-stripe
cc @stripe/api-libraries

Update for API version 2018-09-24:

  • FileUpload is renamed to File (and generally, all FileUploadSomething structs are renamed to FileSomething)
  • change uploads.stripe.com to files.stripe.com
  • fix file links to use api.stripe.com

Ideally, we'd only use files.stripe.com for the file creation request, and api.stripe.com for file retrieve / list requests, but the library's architecture makes that difficult. It's not a huge deal since we will likely keep supporting retrieve and list requests on files.stripe.com in perpetuity.

@brandur-stripe
Copy link
Contributor

LGTM as well!

@ob-stripe
Copy link
Contributor Author

Thanks both!

@ob-stripe ob-stripe merged commit 04092ab into master Sep 27, 2018
@ob-stripe ob-stripe deleted the ob-file-resource branch September 27, 2018 10:22
@ob-stripe
Copy link
Contributor Author

Released as 51.0.0.

nadaismail-stripe pushed a commit that referenced this pull request Oct 18, 2024
Bumps [stripe](https://github.com/stripe/stripe-ruby) from 7.0.0 to 7.1.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases)
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md)
- [Commits](stripe/stripe-ruby@v7.0.0...v7.1.0)

---
updated-dependencies:
- dependency-name: stripe
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants