Add support for the most recent API version #639
Conversation
coupon.go
Outdated
| Name *string `form:"name"` | ||
| PercentOff *int64 `form:"percent_off"` | ||
| RedeemBy *int64 `form:"redeem_by"` | ||
| AmountOff *float64 `form:"amount_off"` |
There was a problem hiding this comment.
Was changing AmountOff and not PercentOff in parameters intentional? It kind of looks like they should both be the same (and I would've thought they'd be floats themselves, but integers seem to still be recommended in the docs).
ptal @remi-stripe
There was a problem hiding this comment.
@brandur-stripe Sorry, I changed the wrong one I think. Only percent_off should be a float. It's for the latest API version we did: https://stripe.com/docs/upgrades#2018-07-27
The percent_off field of coupons was changed from Integer to Float, with a precision of two decimal places.
* Move to API version 2018-07-27 * Remove SKUs list on the product * Remove the ability to pass a Source on subscription creation/update * Change percent_off on the coupon from int to float
remi-stripe
force-pushed
the
remi-add-latest-api-version
branch
from
58c63cb to
258c75a
Compare
|
@brandur-stripe Sorry for the mixup, I fixed the issue and changed |
|
Ah yes, that looks right now. Thanks! |
|
Released as 37.0.0. |
This ensures the most recent API version is set in stripe-go as there were a few breaking changes.
r? @brandur-stripe
cc @stripe/api-libraries