Wire an http.Client from NewBackends through to backends
#627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| httpClient := &http.Client{} | ||
| backends := stripe.NewBackends(httpClient) | ||
| assert.Equal(t, httpClient, backends.API.(*stripe.BackendConfiguration).HTTPClient) | ||
| assert.Equal(t, httpClient, backends.Uploads.(*stripe.BackendConfiguration).HTTPClient) |
There was a problem hiding this comment.
These tests aren't amazing because we have to cast to the private-ish BackendConfiguration. I may remove them in a future refactor, but for now they give us at least some confidence that this fix works correctly.
|
r? @remi-stripe Thanks! |
remi-stripe
approved these changes
Jul 17, 2018
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Bump sfdx * MFA instructions * Scratch setup settings to disable mfa on all ip ranges * Misc notes from hacking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #611 I accidentally introduced a regression in the
NewBackendsfunction in that an
http.Clientpassed into the function isn'tactually wired through to the new backends.
Here we fix that problem by changing the invocations to use
GetBackendWithConfiglike they were supposed to.Fixes #626.