returning an Order is not using common params #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerkovacs
force-pushed
the
tyler/fix-order-returns
branch
from
95c1ae9 to
b94de0a
Compare
|
Tested by spinning up an ephemeral server (using |
tylerkovacs
force-pushed
the
tyler/fix-order-returns
branch
from
b94de0a to
69058af
Compare
|
Thanks a lot Tyler! (It's nice to have a test template now for this kind of thing now too, thanks for adding that.) |
|
Released as 29.2.0. |
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Clientcode is not currently using commonParams when returning an order. As a result, information (such as setting the StripeAccount) is lost.