Adds support for detaching sources from customers #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
reviewed
Oct 9, 2017
| var err error | ||
|
|
||
| if len(params.Customer) > 0 { | ||
| err = c.B.Call("DELETE", fmt.Sprintf("/customers/%v/sources/%v", params.Customer, id), c.Key, body, commonParams, source) |
There was a problem hiding this comment.
Since SourceObjectParams has it defined as
Customer string `form:"customer"`
won't the parameter be posted anyway to the API? I guess you might need to create a SourceDetachParams instead to avoid this issue.
There was a problem hiding this comment.
Good point, though that probably also applies to the Del method on cards and bank accounts then. I'll check!
There was a problem hiding this comment.
Okay, you were entirely correct. Cards and bank accounts aren't affected since Customer has form:"-" in their respective structures.
Fixed by defining a new SourceObjectDetachParams struct.
ob-stripe
force-pushed
the
ob-detach-sources
branch
from
b64e3c9 to
5dbdb89
Compare
|
LGTM. Thanks guys! |
|
Released as 28.2.0. |
nadaismail-stripe
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Validate the sf api key * Add org key to api tests * More edge case tests * Adjust for DB enforced uniqueness * sfdx version bump * Use constant for polling frequency Trying to track down these flaky tests * Deep freeze and deep copy on connector settings * Fixing poll constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries @stan-stripe
Adds support for detaching sources from customers.