Add usage data for stripe client usage #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbroshi-stripe
force-pushed
the
mbroshi/add-client-usage
branch
from
3c4468f to
5658ce1
Compare
mbroshi-stripe
force-pushed
the
mbroshi/add-client-usage
branch
from
5658ce1 to
a1c1ee6
Compare
helenye-stripe
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We would like to get a better sense of how many users are using Stripe Clients (aka.
client.API) vs the global client. This will help us better inform how to update documentation and consider possible changes to the Stripe Client going forward.What?
This sends the string
stripe_clientto telemetry statistics when they are enabled when a Stripe Client was used for that request. It does this by wrapping the existingBackends with ausageBackendthat sets the stringstripe_clienton requests. This string is not sent on the global client, so we can distinguish the two.I also updated a few random tests to use the Stripe Client to add some additional test coverage for this change.
Changelog