Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple breaking API changes #1068

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

remi-stripe
Copy link
Contributor

Multiple breaking API changes:

  • PaymentIntent is now expandable on Charge
  • Percentage was removed as a filter when listing TaxRate
  • Removed RenewalInterval on SubscriptionSchedule
  • Removed Country and RoutingNumber from ChargePaymentMethodDetailsAcssDebit

r? @richardm-stripe
cc @stripe/api-libraries

CreatedRange *RangeQueryParams `form:"created"`
Inclusive *bool `form:"inclusive"`
Percentage *float64 `form:"percentage"`
PercentageRange *TaxRatePercentageRangeQueryParams `form:"percentage"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can/should we delete this TaxRatePercentageRangeQueryParams struct b/c this is the only reference?

Copy link
Contributor

@richardm-stripe richardm-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending comment about maybe unreferenced struct that can be handled now or later

* `PaymentIntent` is now expandable on `Charge`
* `Percentage` was removed as a filter when listing `TaxRate`
* Removed `RenewalInterval` on `SubscriptionSchedule`
* Removed `Country` and `RoutingNumber` from `ChargePaymentMethodDetailsAcssDebit`
@remi-stripe remi-stripe force-pushed the remi-more-breaking-changes branch from c918c5a to ef1f87b Compare April 16, 2020 18:11
@remi-stripe remi-stripe merged commit 87f5f0c into integration-v71 Apr 16, 2020
@remi-stripe remi-stripe deleted the remi-more-breaking-changes branch April 16, 2020 18:17
@brandur brandur mentioned this pull request Apr 16, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants