Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Updates #2290

Merged
merged 7 commits into from
Feb 22, 2021
Merged

API Updates #2290

merged 7 commits into from
Feb 22, 2021

Conversation

richardm-stripe
Copy link
Contributor

Codegen for openapi 403fdb8.
r? @richardm-stripe
cc @stripe/api-libraries

Changelog

  • Added support for new resource BillingPortal.Configuration
  • Added support for configuration and on_behalf_of on Session#create and BillingPortal.Session
  • WebhookEndpoint#create.enabled_events[] and WebhookEndpoint#update.enabled_events[] added new enum members: billing_portal.configuration.created and billing_portal.configuration.updated

Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but I'd prefer if we fixed the test instead to rely on stripe-mock and not a local fixture

[Fact]
public void Deserialize()
{
var json = GetResourceAsString("api_fixtures.billing_portal.configuration.json");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as java, stripe-mock can return the fixture, so we should not be using a fixture here

@richardm-stripe richardm-stripe merged commit cfbf4b8 into master Feb 22, 2021
@richardm-stripe richardm-stripe deleted the latest-codegen branch February 22, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants