Multiple API changes #2257
Merged
Multiple API changes #2257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
commented
Nov 24, 2020
| set => this.InternalAccountTaxIds = SetExpandableArrayObjects(value); | ||
| } | ||
|
|
||
| [JsonProperty("account_tax_ids", ItemConverterType = typeof(ExpandableFieldConverter<AccountTaxId>))] |
There was a problem hiding this comment.
This is wrong and should be TaxId, unclear why that broke
There was a problem hiding this comment.
Fixed internally and updated that PR to reflect the newer state
remi-stripe
force-pushed
the
remi/codegen-35ca85b
branch
from
d1d4dec to
fd4d01b
Compare
richardm-stripe
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple API changes:
AccountTaxIdsonInvoiceSepaDebitinPaymentMethodOptionsonPaymentIntentr? @richardm-stripe
cc @stripe/api-libraries
Codegen for openapi 35ca85b