Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for subscription_proration_behavior on UpcomingInvoiceListLineItemsOptions #2212

Merged
merged 2 commits into from
Sep 30, 2020

Conversation

topherdavis
Copy link
Contributor

subscription_prorate is no longer supported on UpcomingInvoiceListLineItemsOptions

This has been replaced with subscription_proration_behavior. This is updated here.

…ineItemsOptions

This has been replaced with `subscription_proration_behavior`. This is updated here.
@CLAassistant
Copy link

CLAassistant commented Sep 30, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@topherdavis Thanks a lot for doing the work here. While most the library is automatically generated from our openapi spec, this file (and a few others) aren't which is why it slipped through the cracks.

We would need some change on your PR to merge this. Let me know if you want to take of if you prefer I handle directly.

@remi-stripe remi-stripe self-assigned this Sep 30, 2020
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thank you so much for the PR and for taking the time to edit it!

@remi-stripe remi-stripe merged commit d799b1f into stripe:master Sep 30, 2020
@remi-stripe remi-stripe changed the title subscription_prorate is no longer supported on UpcomingInvoiceListL… Add support for subscription_proration_behavior on UpcomingInvoiceListLineItemsOptions Sep 30, 2020
@remi-stripe
Copy link
Contributor

I just released this as 39.10.0, thanks again for taking the work yourself!

@topherdavis
Copy link
Contributor Author

Thanks for releasing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants