Adds TokenPiiOptions for TokenCreateOptions
#2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
approved these changes
Jul 21, 2020
| public class TokenPiiOptions : INestedOptions | ||
| { | ||
| /// <summary> | ||
| /// The <c>IdNumber</c> for the PII, in string form. |
There was a problem hiding this comment.
why the <c> tags here? Shouldn't this just be The personal id number for the PII or similar? Feels like this is trying to reference another property elsewhere. Not blocking though
There was a problem hiding this comment.
It was id_number so I pascal cased it, but again I'm not sure if we'll be able to do this with autogen anyways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TokenPiiOptionsforTokenCreateOptionsr? @remi-stripe
cc @stripe/api-libraries