Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Bancontact, EPS, Giropay and P24 on PaymentMethod #2062

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

remi-stripe
Copy link
Contributor

r? @cjavilla-stripe
cc @stripe/api-libraries

Copy link
Contributor

@cjavilla-stripe cjavilla-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -56,24 +89,64 @@ public Customer Customer
internal ExpandableField<Customer> InternalCustomer { get; set; }
#endregion

/// <summary>
/// Properties specific to Eps PaymentMethod.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non blocking nit, but it looks like we call this EPS in the docs rather than Eps?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll fix all of these with autogen anyways.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think it doesn't really matter though I tried to use the right writing everywhere but I typed that string a lot by hand :p

@remi-stripe remi-stripe merged commit 26074fe into master Jun 3, 2020
@remi-stripe remi-stripe deleted the remi-paymentmethod-new branch June 3, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants