Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RequestedAt being nullable #1963

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Conversation

remi-stripe
Copy link
Contributor

Fixes #1962

This is a breaking change, should it still be done as a minor or should it wait the next major to be safe?

r? @ob-stripe
cc @stripe/api-libraries

Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would release it as a patch version since it fixes a bug.

@stripe-ci stripe-ci assigned remi-stripe and unassigned ob-stripe Mar 23, 2020
@remi-stripe remi-stripe merged commit afbe1b2 into master Mar 23, 2020
@remi-stripe remi-stripe deleted the remi-fix-requested-at branch March 23, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stripe.Capability.RequestedAt is nullable
3 participants