Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CreditNoteLineItem #1896

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

remi-stripe
Copy link
Contributor

@remi-stripe remi-stripe commented Jan 12, 2020

r? @ob-stripe
cc @stripe/api-libraries

@remi-stripe remi-stripe force-pushed the remi-add-creditnote-preview-lines branch 4 times, most recently from 73730ce to 3c240c3 Compare January 13, 2020 23:34
@remi-stripe remi-stripe changed the title WIP PR for credit note line item Add support for CreditNoteLineItem Jan 14, 2020
Copy link
Contributor

@cjavilla-stripe cjavilla-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made it about 75% of the way through with one question. Jumping off for a meeting and nothing is glaring at this point.

@remi-stripe remi-stripe force-pushed the remi-add-creditnote-preview-lines branch from 3c240c3 to 69d2f3b Compare January 14, 2020 19:45
Copy link
Contributor

@cjavilla-stripe cjavilla-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@remi-stripe remi-stripe merged commit 1d12aca into master Jan 14, 2020
@remi-stripe remi-stripe deleted the remi-add-creditnote-preview-lines branch January 14, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants