-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PendingUpdate
and ProrationBehavior
on Subscription
APIs.
#1895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the new events too
src/Stripe.net/Entities/Subscriptions/SubscriptionPendingUpdate.cs
Outdated
Show resolved
Hide resolved
@ob-stripe when you get a chance. I'm generally curious how you think we should handle the |
PendingUpdate
and ProrationBehavior
on Subscription
APIs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitick on the docs + the ones you didn't fix from earlier.
re-assign to @ob-stripe for review as there's some risk with which fields can be nullable on the resource and I never know how to assess this safely
src/Stripe.net/Entities/Subscriptions/SubscriptionPendingUpdate.cs
Outdated
Show resolved
Hide resolved
also it's missing the constants for the events right? |
441471e
to
1df69ab
Compare
Good catch on events, @remi. I noticed it here: https://github.com/stripe/stripe-java/pull/925/files but not in the latest stripe-java PR: https://github.com/stripe/stripe-java/pull/933/files should that be in the latest? I tried testing out the For instance, here's Plan.BillingScheme's docs, which don't seem to link to the properties? |
updated and pretty sure I got the comment references this time. r? @remi-stripe |
1df69ab
to
7e0334f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments re. some nullable or non-nullable resource fields.
Could you also bump stripe-mock while you're at it? Thanks!
src/Stripe.net/Entities/Subscriptions/SubscriptionPendingUpdate.cs
Outdated
Show resolved
Hide resolved
src/Stripe.net/Entities/Subscriptions/SubscriptionPendingUpdate.cs
Outdated
Show resolved
Hide resolved
d00d6ec
to
f39be89
Compare
Flipped the nullability of those two columns and bumped stripe-mock. Thanks for looking @ob-stripe r? @ob-stripe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
I don't feel super confident in the type for
SubscriptionItems
on PendingUpdate here and am just trying to wrap up testing of deserialization locally.r? @remi-stripe
cc @stripe/api-libraries