Flatten SharedOptions into their Create/Update classes for auto-gen prep #1891
Conversation
| public string AccountToken { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Optional information related to the business. |
There was a problem hiding this comment.
The docs today say
Non-essential business information about the account
|
|
||
| /// <summary> | ||
| /// Information about the company or business. This field is null | ||
| /// unless <c>BusinessType</c> is set to <c>company</c>. |
There was a problem hiding this comment.
It's not <c> when you reference another field. Instead, it's <see cref="BusinessType"/> for example so that the IDE can reference the other field.
|
|
||
| /// <summary> | ||
| /// Information about the person represented by the account. This field | ||
| /// is null unless <c>BusinessType</c> is set to <c>individual</c>. |
| /// Use <c>error_if_incomplete</c> if you want Stripe to return an HTTP 402 status code if | ||
| /// a subscription's first invoice cannot be paid. For example, if a payment method requires | ||
| /// 3DS authentication due to SCA regulation and further user action is needed, this | ||
| /// parameter does not create a subscription and returns an error instead. This was the |
There was a problem hiding this comment.
I tend to editorialize those really long descriptions personally though for autogen it won't work
but the part about the API version is irrelevant to dotnet
|
Pretty sure I addressed all the comments. Thanks for reviewing. ptal. r? @remi-stripe |
|
re-assigning to @ob-stripe for review before merging |
There was a problem hiding this comment.
Thanks @cjavilla-stripe! This is much better. In hindsight SharedOptions was not such a good idea.
The PR is too large for me to be able to be 100% confident we haven't changed the public API (except for Issuing.DisputeCreateOptions where you fixed an actual issue), and I unfortunately don't know of an automated way to check, but this LGTM.
Mostly moving SharedOptions into their Create/Update classes and adding docstrings where they were obv missing. This seemed like a useful change in preparation of auto-gen.
r? @remi-stripe
cc @stripe/api-libraries @ob-stripe