Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Created on most resources as it's never nullable #1841

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Change Created on most resources as it's never nullable #1841

merged 1 commit into from
Nov 15, 2019

Conversation

remi-stripe
Copy link
Contributor

Looked at the openapi spec and no created field is nullable today/anymore.

Fixes #1840

r? @ob-stripe
cc @stripe/api-libraries

ob-stripe
ob-stripe approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this is a breaking change.

@stripe-ci stripe-ci assigned remi-stripe and unassigned ob-stripe Nov 15, 2019
@remi-stripe remi-stripe merged commit 9ab8760 into integration-v34 Nov 15, 2019
@remi-stripe remi-stripe deleted the remi-event-created branch November 15, 2019 17:51
@remi-stripe remi-stripe mentioned this pull request Nov 15, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ob-stripe ob-stripe ob-stripe approved these changes

Assignees

@remi-stripe remi-stripe

Labels
approved breaking-api-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remi-stripe @ob-stripe @stripe-ci