Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable test for JSON<->property name consistency #1804

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

Enables the JSON<->property name consistency test.

Adds a AllowNameMismatch attribute to flag allowed exceptions.

@ob-stripe ob-stripe mentioned this pull request Oct 7, 2019
19 tasks
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, but thanks a lot for taking the time to build this!

@ob-stripe ob-stripe force-pushed the ob-enable-test-json-names branch from 9b41aae to 811cf9c Compare October 8, 2019 01:04
@stripe-ci stripe-ci removed the approved label Oct 8, 2019
@ob-stripe
Copy link
Contributor Author

ptal @remi-stripe

@ob-stripe ob-stripe assigned remi-stripe and unassigned ob-stripe Oct 8, 2019
@stripe-ci stripe-ci assigned ob-stripe and unassigned remi-stripe Oct 8, 2019
@ob-stripe ob-stripe merged commit 76f9b04 into integration-v28 Oct 8, 2019
@ob-stripe ob-stripe deleted the ob-enable-test-json-names branch October 8, 2019 20:28
ob-stripe added a commit that referenced this pull request Oct 9, 2019
* Better string enums (#1675)

* Init options with default parameter values (#1699)

* Remove multiple deprecated features (#1713)

Many features were marked as obsolete and are now being removed:
* AccountBalance on Customer, use Balance instead
* Billing on Subscription/Invoice/SubscriptionSchedule, use CollectionMethod instead
* TaxInfo and TaxInfoVerification on Customer, use TaxId instead
* AllowedSourceTypes on PaymentIntent, use PaymentMethodTypes instead
* Start on Subscription, use StartDate instead
* ApplicationFee on Charge, use ApplicationFeeAmount instead
* Date when listing Invoices, use Created instead
* OperatorAccount on all Terminal APIs

* Remove all Expand* fields (#1715)

* Use properl SetupIntent class

* Removed Id and FileId suffixes to stay as close to the API as possible. (#1738)

* Add a test to ensure that JSON names match property names (#1744)

* A few more renames (#1739)

* Remove dead code for service expansions (#1751)

* Bump Stylecop.Analyzers to latest version (#1752)

* Bump SourceLink and create symbol package (#1755)

* Fix all classes not inheriting from the generic version of StripeEntity

* Add a wholesome test to ensure proper JSON converters are applied (#1761)

* Remove more deprecated stuff (#1802)

* Remove more Id/FileId suffixes (#1803)

* One more rename (#1805)

* Fix ExternalAccountUpdateOptions (#1806)

* Rename AccountOpener to Representative and move to latest API version

* Enable test for JSON<->property name consistency (#1804)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants