-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable test for JSON<->property name consistency #1804
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
approved these changes
Oct 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments, but thanks a lot for taking the time to build this!
src/Stripe.net/Services/ExternalAccounts/ExternalAccountUpdateOptions.cs
Outdated
Show resolved
Hide resolved
src/Stripe.net/Services/Sources/SourceThreeDSecureCreateOptions.cs
Outdated
Show resolved
Hide resolved
ob-stripe
force-pushed
the
ob-enable-test-json-names
branch
from
October 8, 2019 01:04
9b41aae
to
811cf9c
Compare
ptal @remi-stripe |
remi-stripe
approved these changes
Oct 8, 2019
ob-stripe
added a commit
that referenced
this pull request
Oct 8, 2019
ob-stripe
added a commit
that referenced
this pull request
Oct 9, 2019
* Better string enums (#1675) * Init options with default parameter values (#1699) * Remove multiple deprecated features (#1713) Many features were marked as obsolete and are now being removed: * AccountBalance on Customer, use Balance instead * Billing on Subscription/Invoice/SubscriptionSchedule, use CollectionMethod instead * TaxInfo and TaxInfoVerification on Customer, use TaxId instead * AllowedSourceTypes on PaymentIntent, use PaymentMethodTypes instead * Start on Subscription, use StartDate instead * ApplicationFee on Charge, use ApplicationFeeAmount instead * Date when listing Invoices, use Created instead * OperatorAccount on all Terminal APIs * Remove all Expand* fields (#1715) * Use properl SetupIntent class * Removed Id and FileId suffixes to stay as close to the API as possible. (#1738) * Add a test to ensure that JSON names match property names (#1744) * A few more renames (#1739) * Remove dead code for service expansions (#1751) * Bump Stylecop.Analyzers to latest version (#1752) * Bump SourceLink and create symbol package (#1755) * Fix all classes not inheriting from the generic version of StripeEntity * Add a wholesome test to ensure proper JSON converters are applied (#1761) * Remove more deprecated stuff (#1802) * Remove more Id/FileId suffixes (#1803) * One more rename (#1805) * Fix ExternalAccountUpdateOptions (#1806) * Rename AccountOpener to Representative and move to latest API version * Enable test for JSON<->property name consistency (#1804)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @remi-stripe
cc @stripe/api-libraries
Enables the JSON<->property name consistency test.
Adds a
AllowNameMismatch
attribute to flag allowed exceptions.