Allow VoidedAt on CreditNote to be nullable #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically, yeah, it is. |
|
@ob-stripe Yeah I know it technically is, but is it in this case? I'm assuming almost no one could deserialize CreditNote until that fix |
|
Yeah, we can probably release this as a patch or minor since it's really a bug fix, with a note that it's technically breaking. |
|
I'm happy to wait for the next major otherwise if it's coming soon. Can I leave to you otherwise? |
|
Released as 29.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1782
r? @ob-stripe
cc @stripe/api-libraries
Is this a breaking change?