Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CollectionMethod for Invoices and Subscriptions #1679

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Add CollectionMethod for Invoices and Subscriptions #1679

merged 1 commit into from
Jul 2, 2019

Conversation

cjavilla-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

remi-stripe
remi-stripe requested changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on things to change. Don't action on the enum one until @ob-stripe has shared his opinion

src/Stripe.net/Entities/Invoices/Invoice.cs Show resolved Hide resolved
src/Stripe.net/Entities/Invoices/InvoiceLineItem.cs Show resolved Hide resolved
src/Stripe.net/Enums/Billing.cs Outdated Show resolved Hide resolved
@cjavilla-stripe
Copy link
Contributor Author

r? @remi-stripe

@cjavilla-stripe cjavilla-stripe force-pushed the cjavilla/add-collection-method branch from b9e7738 to 7e6f993 Compare June 26, 2019 19:50
@cjavilla-stripe
Copy link
Contributor Author

r? @remi-stripe

@cjavilla-stripe cjavilla-stripe force-pushed the cjavilla/add-collection-method branch from 7e6f993 to 94929e3 Compare June 26, 2019 19:55
@cjavilla-stripe
Copy link
Contributor Author

r? @remi-stripe

@remi-stripe
Copy link
Contributor

Changes lgtm. Assigning to @ob-stripe for approval.

@cjavilla-stripe cjavilla-stripe force-pushed the cjavilla/add-collection-method branch from 5130043 to 94929e3 Compare June 27, 2019 17:33
@cjavilla-stripe
Copy link
Contributor Author

r? @remi-stripe

@cjavilla-stripe
Copy link
Contributor Author

@ob-stripe added CollectionMethod to update invoice params.

@cjavilla-stripe cjavilla-stripe force-pushed the cjavilla/add-collection-method branch 2 times, most recently from 7f04cfb to 296a1c3 Compare July 2, 2019 16:03
@cjavilla-stripe
Copy link
Contributor Author

r? @ob-stripe

Rebased and tested on latest stripe-mock

@remi-stripe remi-stripe assigned remi-stripe and unassigned ob-stripe Jul 2, 2019
ob-stripe
ob-stripe suggested changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, lgtm otherwise.

src/Stripe.net/Enums/Billing.cs Outdated Show resolved Hide resolved
@cjavilla-stripe cjavilla-stripe force-pushed the cjavilla/add-collection-method branch from 296a1c3 to aefacf9 Compare July 2, 2019 17:51
@cjavilla-stripe
Copy link
Contributor Author

r? @ob-stripe

ob-stripe
ob-stripe approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please squash your commits before merging?

@ob-stripe ob-stripe removed the approved label Jul 2, 2019
@cjavilla-stripe cjavilla-stripe force-pushed the cjavilla/add-collection-method branch from aefacf9 to 8fcdba1 Compare July 2, 2019 18:12
@cjavilla-stripe
Copy link
Contributor Author

Squashed. I was told never to merge these, so I'm reassigning to @remi-stripe :)

@cjavilla-stripe cjavilla-stripe force-pushed the cjavilla/add-collection-method branch from 8fcdba1 to 07c9330 Compare July 2, 2019 18:22
remi-stripe
remi-stripe requested changes Jul 2, 2019
View reviewed changes
src/Stripe.net/Services/Invoices/InvoiceCreateOptions.cs Outdated
/// </summary>
[JsonProperty("collection_method")]
public string CollectionMethod { get; set; }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't flag them all originally and wanted you to recheck each one. That one should be before Customer and CustomFields

src/Stripe.net/Services/SubscriptionSchedules/SubscriptionScheduleSharedOptions.cs Outdated
/// </summary>
[JsonProperty("collection_method")]
public string CollectionMethod { get; set; }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be before DefaultSourceId and DefaultPaymentMethodId

@cjavilla-stripe cjavilla-stripe force-pushed the cjavilla/add-collection-method branch from 07c9330 to abc7011 Compare July 2, 2019 18:39
@cjavilla-stripe
Copy link
Contributor Author

@remi-stripe sorry, I thought since there were two comments those were the only two. I rechecked them all, I'm not sure if that one should go after the collapsable charge block or not, not sure how those regions work.

remi-stripe
remi-stripe approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the fixes. Approving

@remi-stripe remi-stripe merged commit 414a4eb into master Jul 2, 2019
@remi-stripe remi-stripe deleted the cjavilla/add-collection-method branch July 2, 2019 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ob-stripe ob-stripe ob-stripe approved these changes

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees

@cjavilla-stripe cjavilla-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjavilla-stripe @remi-stripe @ob-stripe @stripe-ci