Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file creation requests #1657

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Fix file creation requests #1657

merged 1 commit into from
Jun 10, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

So there were actually three different issues 🤦‍♂

  1. File creation requests were sent to api.stripe.com instead of files.stripe.com
  2. Field names in multipart requests must be quoted
  3. FileLink.ExpiresAt is nullable

Fixes #1654.

@stripe-ci stripe-ci assigned ob-stripe and unassigned remi-stripe Jun 10, 2019
@ob-stripe ob-stripe merged commit ebfd561 into master Jun 10, 2019
@ob-stripe ob-stripe deleted the ob-fix-1654 branch June 10, 2019 21:06
@ob-stripe
Copy link
Contributor Author

Released as 27.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid UTF-8 characters after upgrade to 27.0
3 participants