Add BECS Source Type #1568
Add BECS Source Type #1568
Conversation
There was a problem hiding this comment.
Great work @shengwei-stripe this is looking really good! I left some minor comments about styling to try and be consistent across the library but otherwise this looks ready!
| @@ -0,0 +1,19 @@ | |||
| namespace Stripe | |||
There was a problem hiding this comment.
This should be named SourceAuBecsDebit since that's the name of the whole type.
| public string Last3 { get; set; } | ||
|
|
||
| [JsonProperty("fingerprint")] | ||
| public string Fingerprint { get; set; } |
There was a problem hiding this comment.
This should all be ordered alphabetically.
| @@ -0,0 +1,13 @@ | |||
| namespace Stripe | |||
There was a problem hiding this comment.
Same for naming, you're missing Au in the name (won't say it for others)
| public string BsbNumber { get; set; } | ||
|
|
||
| [JsonProperty("account_number")] | ||
| public string AccountNumber { get; set; } |
There was a problem hiding this comment.
Order alphabetically (won't say for the other ones)
| @@ -0,0 +1,12 @@ | |||
| namespace Stripe | |||
There was a problem hiding this comment.
This and the other one should be SourceMandateAcceptanceOfflineOptions instead.
|
@remi-stripe thanks for the review. As discussed, I have made the fix
Let me know if it looks ok. Thank you :) |
|
Thanks for the fixes @shengwei-stripe, this looks great now. Re-assigning to @ob-stripe to vet the PR and do the release tomorrow! |
|
Released as 25.4.0. |
OnlineandOfflinetypePlease comment on
E.g.
BecsDebitvsAuBecsDebit,SourceMandateOnlineOptionsandSourceMandateOfflineOptions