Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for latest_invoice on Subscription #1545

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

remi-stripe
Copy link
Contributor

Add support for expanding latest_invoice on Subscription. This also fixed a test that is now failing as destination` on Charge is now undocumented and not in openapi anymore

r? @mickjermsurawong-stripe
cc @stripe/api-libraries

@mickjermsurawong-stripe

@remi-stripe
latest invoice looks good. It reads correctly, and I pattern matched with previous implementation which looks fine. This is consistent with stripe-java too.
The build failure is that stripe-mock is not running, I assume it's the same versioning problem. Please feel free to merge once you resolve stripe-mock
LGTM

Also fixes a test that is broken with the latest openapi spec as this
property is now undocumented.
@remi-stripe remi-stripe force-pushed the remi-add-latest-invoice branch from f67b10f to 6d0f3c2 Compare February 28, 2019 17:07
@remi-stripe
Copy link
Contributor Author

just rebased on the latest master to confirm tests still passed. Approving

@remi-stripe remi-stripe merged commit b3d47ca into master Feb 28, 2019
@remi-stripe remi-stripe deleted the remi-add-latest-invoice branch February 28, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants