Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @remi-stripe
cc @stripe/api-libraries
This PR removes the
Mapper
helper class, as well as lots of now-unused code inRequestor
.This is technically a breaking API change, but most users shouldn't be impacted:
Mapper
was public, so some users might be usingMapper<StripeEntityType>.MapFromJson()
to deserialize Stripe objects. Users can still deserialize Stripe objects by callingStripeEntityType.FromJson()
, or directly callingNewtonsoft.Json.JsonConvert.DeserializeObject<StripeEntityType>()
StripeResponse.ObjectJson
is removed. I don't think it was particularly useful. (The full JSON is still available inResponseJson
.)