Move base URLs out of resource services where possible #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
commented
Jan 28, 2019
| return Mapper<File>.MapFromJson( | ||
| Requestor.PostFile( | ||
| this.ClassUrl(StripeConfiguration.FilesBase), | ||
| StripeConfiguration.FilesBase + this.ClassUrl(), |
There was a problem hiding this comment.
Technically, setting requestOptions.BaseUrl is useless here because the method doesn't call Service.Request. That's only temporary because Service.Request doesn't support multipart encoding yet, but I'll fix that later. In the meantime, this ensure that requestOptions.BaseUrl is consistent with the URL that is passed to Requestor.PostFile.
remi-stripe
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe @remi-stripe
cc @stripe/api-libraries
Simply base URL handling by centralizing it into
Servicebase class.Individual services can override the base URL in one of two ways:
BaseUrlproperty for the service itself, which will set the base URL for all methods in the service (e.g.OAuthTokenService)BaseUrlproperty inRequestOptions, which will set the base URL for the specific request (e.g.FileService.Create / CreateAsync)