Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary uses of Mapper #1480

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Remove unnecessary uses of Mapper #1480

merged 1 commit into from
Jan 21, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe @remi-stripe
cc @stripe/api-libraries

  • Replace most uses of Mapper<T>.MapFromJson() with JsonConvert.DeserializeObject<T>()
  • Remove Mapper<T>.MapCollectionFromJson() methods (they weren't used anymore)

@ob-stripe ob-stripe changed the base branch from master to integration-v23 January 21, 2019 12:50
@ob-stripe ob-stripe merged commit f59ff17 into integration-v23 Jan 21, 2019
@ob-stripe ob-stripe deleted the ob-clean-mapper branch January 21, 2019 20:19
@ob-stripe ob-stripe mentioned this pull request Jan 21, 2019
Merged
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ob-stripe @remi-stripe