Refactor test infrastructure #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
commented
Dec 21, 2018
| : base(stripeMockFixture) | ||
| { | ||
| } | ||
|
|
There was a problem hiding this comment.
This test (and some others) doesn't rely on GetFixture, so it doesn't need to receive the StripeMockFixture instance. My codemod wasn't smart enough to figure that out though, and it's probably best to be consistent anyway.
ob-stripe
commented
Dec 21, 2018
| var exception = Assert.Throws<StripeException>(() => | ||
| new CouponService().Create(new CouponCreateOptions())); | ||
| var exception = await Assert.ThrowsAsync<StripeException>(async () => | ||
| await new CouponService().CreateAsync(new CouponCreateOptions())); |
There was a problem hiding this comment.
I changed this test to work around the weirdest Mono issue. With the previous sync version, for some reason this test would work but take exactly 100 seconds to run with Mono. I've really tried to figure out the root cause but came up with nothing. Changing this to async makes the test works instantly with Mono and doesn't change anything for the test's purposes.
remi-stripe
approved these changes
Dec 21, 2018
ob-stripe
force-pushed
the
ob-refactor-test-infra
branch
from
e5175fd to
8b5a863
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @remi-stripe
cc @stripe/api-libraries
Alright, some context first. When I initialized the new
StripeTestsstripe-mock based suite a few months back, I set up a hack using aLazy<>object to ensure the initialization (e.g. checking stripe-mock's version) is only done once.This worked, but it's definitely not how this sort of things should be done with xUnit. Also, while this worked for initializing stuff, it doesn't work for cleaning stuff up afterwards. We handled that by simply not cleaning anything up.
This PR reworks the test suite to do things the proper way. All stripe-mock based tests are now grouped in a "collection". Tests in the same collection are run sequentially, and can share collection fixtures.
Two collection fixtures are added:
MockHttpClientFixtureis used to manage the mock HTTP client, for things like asserting requests (and in the future, stubbing requests)StripeMockFixtureis used to manage stripe-mockThe most annoying part of this PR is that test classes that rely on a particular fixture must define a constructor to receive the fixture instance and pass it to the base constructor. I've added helpful error messages to detect when a test class relies on a fixture but didn't define the needed constructor.
The big motivation behind this PR is that I want to port stripe/stripe-ruby#715 to stripe-dotnet, but to do so I need to be able to set up a global teardown function (in order to stop the stripe-mock process if the test suite starts its own).