Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make object instances in tests readonly #1436

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Conversation

ob-stripe
Copy link
Contributor

It's good practice to declare fields that are only assigned in constuctors as readonly.

@ob-stripe ob-stripe mentioned this pull request Dec 14, 2018
29 tasks
@ob-stripe
Copy link
Contributor Author

Tests still pass, and only test files were modified in this PR, so going to self-approve.

@ob-stripe ob-stripe self-assigned this Dec 14, 2018
@ob-stripe ob-stripe merged commit 4f0d5cf into integration-v23 Dec 14, 2018
@ob-stripe ob-stripe deleted the ob-readonly branch December 14, 2018 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant