Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for verifying sources #1417

Merged
merged 1 commit into from
Dec 10, 2018
Merged

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

Add support for verifying sources.

Fixes one of the remaining tasks in #1066.

@ob-stripe ob-stripe mentioned this pull request Dec 10, 2018
29 tasks
/// The values needed to verify the source.
/// </summary>
[JsonProperty("values")]
public List<string> Values { get; set; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is supposed to be a string and not an int right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it's specified as an array of strings, presumably because the values can be more or less anything depending on the source's type.

@ob-stripe ob-stripe self-assigned this Dec 10, 2018
@ob-stripe ob-stripe merged commit bcbcf4c into integration-v23 Dec 10, 2018
@ob-stripe ob-stripe deleted the ob-source-verify branch December 10, 2018 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants