Add support for flat_amount on Plan tiers.
#1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
suggested changes
Nov 7, 2018
| @@ -4,6 +4,9 @@ namespace Stripe | |||
|
|
|||
| public class PlanTier : StripeEntity | |||
| { | |||
| [JsonProperty("flat_amount")] | |||
| public long FlatAmount { get; set; } | |||
There was a problem hiding this comment.
This should be nullable.
(UnitAmount should be nullable too btw, but I guess that'd be a breaking change, so let's fix in the next major version.)
There was a problem hiding this comment.
Well, a user just reported a breakage because UnitAmount is not nullable (#1375) so let's try and fix that ASAP.
There was a problem hiding this comment.
Well this is going in a breaking release already so fixing now.
remi-stripe
force-pushed
the
remi-plan-add-flat-amount
branch
from
d9bfaf9 to
7cd3e72
Compare
|
@ob-stripe Fixed, PTAL |
|
This fixes #1375 |
ob-stripe
approved these changes
Nov 7, 2018
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ob-stripe
cc @stripe/api-libraries
Fixes #1375.