Add unit_label and active fields for creating/updating Products #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
requested changes
Oct 31, 2018
There was a problem hiding this comment.
AFAICT this is correct since you can either create a Product via https://stripe.com/docs/api#create_product but also when creating a plan and passing inline product details.
Since you're fixing this, would you mind adding active since it's also documented in https://stripe.com/docs/api/plans/create#create_plan-product-active but not supported? Can you also re-order properties alphabetically?
karlr-stripe
changed the title
|
ptal @remi-stripe |
remi-stripe
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @remi-stripe
cc @stripe/api-libraries
Attempts to fix #1363. It's quite likely I haven't understood the PlanProductCreateOptions versus ProductSharedOptions distinction though, so let me know if I should do this in a different way.