Add support for new methods on the Invoice resource #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
force-pushed
the
remi-add-invoice-methods
branch
from
e0be641 to
bd0098f
Compare
|
Removing ob since this can not be released before we have the new API version ready. |
remi-stripe
changed the title
ob-stripe
force-pushed
the
integration-next-major-version
branch
2 times, most recently
from
c6704cd to
e9fd90d
Compare
ob-stripe
changed the base branch from
integration-next-major-version
to
master
remi-stripe
force-pushed
the
remi-add-invoice-methods
branch
from
bd0098f to
cb17623
Compare
3 tasks
remi-stripe
force-pushed
the
remi-add-invoice-methods
branch
2 times, most recently
from
67198e4 to
f9bbae7
Compare
remi-stripe
changed the title
| @@ -38,6 +38,9 @@ public class InvoiceCreateOptions : BaseOptions | |||
| [JsonProperty("days_until_due")] | |||
| public long? DaysUntilDue { get; set; } | |||
|
|
|||
| [JsonProperty("default_source")] | |||
| public string DefaultSource { get; set; } | |||
|
|
|||
There was a problem hiding this comment.
If AutoAdvance belongs in InvoiceParams in Go, doesn't it belong in either create or update here too?
There was a problem hiding this comment.
Awesome, nice catch. I totally missed those 2 when I did the PR. Fixed, PTAL
remi-stripe
force-pushed
the
remi-add-invoice-methods
branch
from
f9bbae7 to
8398df4
Compare
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change as it will be linked to a new API version since we are removing some fields.
cc @stripe/api-libraries