Add support for the Person resource #1332
Conversation
| public bool SsnLast4Provided { get; set; } | ||
|
|
||
| [JsonProperty("verification")] | ||
| public LegalEntityVerification Verification { get; set; } |
There was a problem hiding this comment.
Should we take this as an opportunity to rename some of those classes to not be so specific since they will soon be shared across Person and Account.
There was a problem hiding this comment.
I'd keep the current name for now. A person is also a legal entity.
There was a problem hiding this comment.
Yeah but the concept of LegalEntity is going away soon that's why I was asking since we will have to rename it
There was a problem hiding this comment.
Let's cross that bridge when we get to it? This PR doesn't have breaking changes, so I don't see any upside to doing this now rather than later.
remi-stripe
force-pushed
the
remi-add-person
branch
from
38fe0e0 to
5e9b6d2
Compare
ob-stripe
force-pushed
the
integration-next-major-version
branch
2 times, most recently
from
c6704cd to
e9fd90d
Compare
ob-stripe
changed the base branch from
integration-next-major-version
to
master
remi-stripe
force-pushed
the
remi-add-person
branch
2 times, most recently
from
f1ad803 to
43c30d1
Compare
| public string Phone { get; set; } | ||
|
|
||
| [JsonProperty("relationship")] | ||
| public Relationship Relationship { get; set; } |
There was a problem hiding this comment.
Should this be named PersonRelationship to avoid future conflicts? I'm trying to not over-prefix.
There was a problem hiding this comment.
Yeah, I'd rename Relationship to PersonRelationship and Requirements to PersonRequirements to match the OpenAPI names.
There was a problem hiding this comment.
Requirements will be shared with Accounts so I'd rather not prefix it Person
|
r? @ob-stripe |
remi-stripe
force-pushed
the
remi-add-person
branch
2 times, most recently
from
16bc53c to
b0fca33
Compare
remi-stripe
changed the title
| public string Phone { get; set; } | ||
|
|
||
| [JsonProperty("relationship")] | ||
| public Relationship Relationship { get; set; } |
There was a problem hiding this comment.
Yeah, I'd rename Relationship to PersonRelationship and Requirements to PersonRequirements to match the OpenAPI names.
| public class RelationshipListOptions : INestedOptions | ||
| { | ||
| [JsonProperty("account_opener")] | ||
| public bool? AccountOpener { get; set; } |
There was a problem hiding this comment.
This property isn't present in the OpenAPI spec or supported by the API.
There was a problem hiding this comment.
It is, just not in this release but it was overlooked and since I know it will be supported it seemed cleaner to just release now.
| @@ -19,7 +19,7 @@ public void Deserialize() | |||
|
|
|||
| Assert.NotNull(evt.Data); | |||
| Assert.NotNull(evt.Data.Object); | |||
| Assert.IsType<Customer>(evt.Data.Object); | |||
| Assert.IsType<Plan>(evt.Data.Object); | |||
There was a problem hiding this comment.
Maybe we should just remove this assertion and add tests with local fixtures to ensure that resources in events are correctly deserialized.
| public bool SsnLast4Provided { get; set; } | ||
|
|
||
| [JsonProperty("verification")] | ||
| public LegalEntityVerification Verification { get; set; } |
There was a problem hiding this comment.
I'd keep the current name for now. A person is also a legal entity.
remi-stripe
force-pushed
the
remi-add-person
branch
from
b0fca33 to
ef8a5fa
Compare
|
@ob-stripe PTAL |
cc @stripe/api-libraries
r? @ob-stripe