Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use longs instead of ints #1331

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Use longs instead of ints #1331

merged 1 commit into from
Oct 11, 2018

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

Use longs (64-bit integers) instead of ints (32-bit integers) for all integral types in the API.

I've checked that we're already using decimal (the type with maximal precision) for all floating point types.

Fixes #1330.

@ob-stripe ob-stripe changed the title Use longs instead of ints Use longs instead of ints Oct 10, 2018
@ob-stripe ob-stripe mentioned this pull request Oct 10, 2018
Merged
32 tasks
remi-stripe
remi-stripe approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a test to ensure no one uses int moving forward?

@ob-stripe ob-stripe merged commit a633d10 into integration-next-major-version Oct 11, 2018
@ob-stripe ob-stripe deleted the ob-unify-numeric-types branch October 11, 2018 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ob-stripe @remi-stripe